[Mesa-dev] [PATCH 07/15] spirv/nir: Set info.gs.uses_end_primitive

Jason Ekstrand jason at jlekstrand.net
Fri Jul 20 16:32:53 UTC 2018


This should already be handled by nir_gather_info.  Is there some reason 
why we need to do it here as well?

On July 20, 2018 08:09:26 Alejandro PiƱeiro <apinheiro at igalia.com> wrote:

> From: Neil Roberts <nroberts at igalia.com>
>
> Whenever SpvOpEndPrimitive or SpvOpEndStreamPrimitive is encountered
> it now sets uses_end_primitive to true. This reflects the code in
> validate_geometry_shader_emissions for GLSL.
> ---
> src/compiler/spirv/spirv_to_nir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/spirv/spirv_to_nir.c 
> b/src/compiler/spirv/spirv_to_nir.c
> index 238298a8340..4d297e60b60 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -3208,6 +3208,7 @@ vtn_handle_barrier(struct vtn_builder *b, SpvOp opcode,
>       case SpvOpEndPrimitive:
>       case SpvOpEndStreamPrimitive:
>          intrinsic_op = nir_intrinsic_end_primitive;
> +         b->shader->info.gs.uses_end_primitive = true;
>          break;
>       default:
>          unreachable("Invalid opcode");
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev





More information about the mesa-dev mailing list