[Mesa-dev] [PATCH] nir: Fix end of function without return warning/error.

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Fri, Jul 20, 2018 at 11:01 AM Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
wrote:

> There always is a continue block, so let us just do unreachable.
>
> Fixes: 8cacf38f527 "nir: Do not use continue block after removing it."
> CC: 18.1 <mesa-stable at lists.freedesktop.org>
> CC: Mark Janes <mark.a.janes at intel.com>
> ---
>  src/compiler/nir/nir_opt_if.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/nir/nir_opt_if.c
> index 49ba5de09e9..b3d0bf1decb 100644
> --- a/src/compiler/nir/nir_opt_if.c
> +++ b/src/compiler/nir/nir_opt_if.c
> @@ -44,6 +44,8 @@ find_continue_block(nir_loop *loop)
>        if (pred_entry->key != prev_block)
>           return (nir_block*)pred_entry->key;
>     }
> +
> +   unreachable("Continue block not found!");
>  }
>
>  /**
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180720/ec81a403/attachment.html>