[Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

[Gert Wollny]

Am Samstag, den 21.07.2018, 11:33 -0400 schrieb Ilia Mirkin:
> 
> 
> On Sat, Jul 21, 2018, 05:45 Gert Wollny <gert.wollny at collabora.com>
> wrote:
> > Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin:
> > > 
> > > > +   /* Allow 3-comp 32 bit texturs only for TBOs (needed for
> > > > ARB_tbo_rgb32) */
> > > > +   if ((format == PIPE_FORMAT_R32G32B32_FLOAT ||
> > > > +       format == PIPE_FORMAT_R32G32B32_SINT ||
> > > > +       format == PIPE_FORMAT_R32G32B32_UINT) &&
> > > > +       target != PIPE_BUFFER)
> > > > +      return FALSE;
> > > 
> > > My personal recommendation would be to disallow *all* packed RGB
> > > formats unless target == PIPE_BUFFER. (And even then --
> > questionable,
> > > except for RGB32, which is required.)
> > > 
> > RGB8 and RGB16 are disabled/replaced by RGBX* on the host side, and
> > R11G11B10 doesn't seem to make problems. 
> 
> No other driver supports these. What happens on the host side is
> hidden from virgl. 
Not exactly, of course the host tells virgl what formats are supported,
and we test using dEQP and piglit quite heavily to get things right, so
I'm quite confident that whatever problem comes up, we will catch it.

Cheers, 
Gert