[Mesa-dev] [PATCH v2] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

[Lionel Landwerlin]

Thanks Alex!

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 23/07/18 09:51, Alex Smith wrote:
> According to the spec, these should apply to all read/write access
> types (so would be equivalent to specifying all other access types
> individually). Currently, they were doing nothing.
>
> v2: Handle VK_ACCESS_MEMORY_WRITE_BIT in dstAccessMask.
>
> Signed-off-by: Alex Smith <asmith at feralinteractive.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/intel/vulkan/anv_private.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index cec2842792..1660fcbbc8 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -1731,6 +1731,9 @@ anv_pipe_flush_bits_for_access_flags(VkAccessFlags flags)
>            pipe_bits |= ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT;
>            pipe_bits |= ANV_PIPE_DEPTH_CACHE_FLUSH_BIT;
>            break;
> +      case VK_ACCESS_MEMORY_WRITE_BIT:
> +         pipe_bits |= ANV_PIPE_FLUSH_BITS;
> +         break;
>         default:
>            break; /* Nothing to do */
>         }
> @@ -1761,6 +1764,12 @@ anv_pipe_invalidate_bits_for_access_flags(VkAccessFlags flags)
>         case VK_ACCESS_TRANSFER_READ_BIT:
>            pipe_bits |= ANV_PIPE_TEXTURE_CACHE_INVALIDATE_BIT;
>            break;
> +      case VK_ACCESS_MEMORY_READ_BIT:
> +         pipe_bits |= ANV_PIPE_INVALIDATE_BITS;
> +         break;
> +      case VK_ACCESS_MEMORY_WRITE_BIT:
> +         pipe_bits |= ANV_PIPE_FLUSH_BITS;
> +         break;
>         default:
>            break; /* Nothing to do */
>         }