[Mesa-dev] [PATCH] virgl: remove unused stride-arguments
airlied at gmail.com
Mon Jul 23 20:05:05 UTC 2018
On 20 July 2018 at 13:39, Gurchetan Singh <gurchetansingh at chromium.org> wrote:
> Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
> On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
>> The IOCTLs doesn't pass this along, so computing them in the first
>> place is kinda pointless.
>> Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
>> This is just a cleanup I noticed based on some discussion with Gert.
>> A question is, what code here expects this stride to be respected? The
>> call-sites in virgl_*_transfer_map and virgl_*_transfer_unmap kinda
>> looks like they do... They'll get a bit of a surprise here, no?
>> Anyway, this is already broken, so I think this should be OK. But
>> perhaps this patch shows some code-paths that need some love?
I reverted this as it didn't fixup vtest, and it introduced build time warnings.
I agree this should get some more investigation but make sure vtest and
drm backends don't regress.
More information about the mesa-dev