[Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

[Lionel Landwerlin]

That looks correct to me (and we do the same in Anv).
Also a bit baffled that we haven't run into issues earlier :(

But would be good to have Ken's Rb too.

Thanks a lot!

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 24/07/18 12:50, Sergii Romantsov wrote:
> Kernel (for ppgtt) requires memory address to be
> aligned to page size (4096).
> Added such alignment for buffers marked with EXEC_OBJECT_PINNED.
>
> -v2: added marking that also fixes initial commit 01058a552294
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106997
> Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.)
> Fixes: 01058a552294 (i965: Add virtual memory allocator infrastructure to brw_bufmgr.)
> Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
> ---
>   src/mesa/drivers/dri/i965/brw_bufmgr.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> index 09d45e3..8383735 100644
> --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c
> +++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> @@ -643,7 +643,7 @@ retry:
>      bo->kflags = bufmgr->initial_kflags;
>   
>      if ((bo->kflags & EXEC_OBJECT_PINNED) && bo->gtt_offset == 0ull) {
> -      bo->gtt_offset = vma_alloc(bufmgr, memzone, bo->size, 1);
> +      bo->gtt_offset = vma_alloc(bufmgr, memzone, bo->size, 4096);
>   
>         if (bo->gtt_offset == 0ull)
>            goto err_free;
> @@ -784,7 +784,7 @@ brw_bo_gem_create_from_name(struct brw_bufmgr *bufmgr,
>      bo->kflags = bufmgr->initial_kflags;
>   
>      if (bo->kflags & EXEC_OBJECT_PINNED)
> -      bo->gtt_offset = vma_alloc(bufmgr, BRW_MEMZONE_OTHER, bo->size, 1);
> +      bo->gtt_offset = vma_alloc(bufmgr, BRW_MEMZONE_OTHER, bo->size, 4096);
>   
>      _mesa_hash_table_insert(bufmgr->handle_table, &bo->gem_handle, bo);
>      _mesa_hash_table_insert(bufmgr->name_table, &bo->global_name, bo);
> @@ -1424,7 +1424,7 @@ brw_bo_gem_create_from_prime_internal(struct brw_bufmgr *bufmgr, int prime_fd,
>   
>      if (bo->kflags & EXEC_OBJECT_PINNED) {
>         assert(bo->size > 0);
> -      bo->gtt_offset = vma_alloc(bufmgr, BRW_MEMZONE_OTHER, bo->size, 1);
> +      bo->gtt_offset = vma_alloc(bufmgr, BRW_MEMZONE_OTHER, bo->size, 4096);
>      }
>   
>      if (tiling_mode < 0) {