[Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.
Roland Scheidegger
sroland at vmware.com
Tue Jul 24 13:38:45 UTC 2018
Am 24.07.2018 um 14:58 schrieb Jose Fonseca:
> Now we do full S3TC decompression they should no longer fail.
> ---
> src/gallium/tests/unit/u_format_test.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/src/gallium/tests/unit/u_format_test.c b/src/gallium/tests/unit/u_format_test.c
> index 6de581fd049..437cc94b757 100644
> --- a/src/gallium/tests/unit/u_format_test.c
> +++ b/src/gallium/tests/unit/u_format_test.c
> @@ -380,11 +380,6 @@ test_format_unpack_rgba_8unorm(const struct util_format_description *format_desc
> if (util_is_double_nan(test->unpacked[0][0][0]))
> success = TRUE;
>
> - /* Ignore S3TC errors */
> - if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {
> - success = TRUE;
> - }
> -
> if (!success) {
> print_unpacked_rgba_8unorm(format_desc, "FAILED: ", unpacked, " obtained\n");
> print_unpacked_rgba_8unorm(format_desc, " ", expected, " expected\n");
>
Looks good to me.
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
More information about the mesa-dev
mailing list