[Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms
emil.l.velikov at gmail.com
Tue Jul 24 16:23:42 UTC 2018
Having a closer look inspired by Eric's comments
On 24 July 2018 at 15:37, Danylo Piliaiev <danylo.piliaiev at gmail.com> wrote:
>>> Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler.
As you bump the libdrm version:
- drop the existing DRM_EVENT_CONTEXT_VERSION guard
- swap the DRM_EVENT_CONTEXT_VERSION macro with the actual version implemented
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107170
Separate bugs it seems - hence separate patches?
>> There is no need for yet another version - just bump LIBDRM_REQUIRED.
> Bumping LIBDRM_REQUIRED would mean that older platforms won't be supported.
> I don't know how the decisions about support of older platforms are made but
> from my point of view bumping required libdrm version due to one vulkan
> may be overkill.
If we consider this as the only merit, then the number of
checks/version would practically explore.
Simply take each user libGL, libEGL, gbm, other multiply that with the
number of features we use.
Looking at Eero's bug (last one in the list) - he's using Ubuntu 16.04
which has 2.4.91 in xenial-updates
>> Why do we need the new define? From a quick look we should be above to
>> reuse VK_USE_PLATFORM_DISPLAY_KHR, we simply need the ifdef guards.
> If we will not bump global libdrm version requirement new define is
> necessary because
> rest of the code guarded by VK_USE_PLATFORM_DISPLAY_KHR works fine with
> older libdrm versions.
And by addressing that, this can go - one diverging codepath less ;-)
More information about the mesa-dev