[Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

Kenneth Graunke kenneth at whitecape.org
Tue Jul 24 17:34:30 UTC 2018

On Tuesday, July 24, 2018 5:34:57 AM PDT Lionel Landwerlin wrote:
> That looks correct to me (and we do the same in Anv).
> Also a bit baffled that we haven't run into issues earlier :(
> But would be good to have Ken's Rb too.
> Thanks a lot!
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

Yeah, this is probably for the best...we used to just ask the kernel
for memory and it would do this for us.  Now that we're doing it
ourselves, we ought to be defensive here.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

But I agree with Chris, I'm surprised that this would actually fix
anything...all of our allocations ought to multiples of PAGE_SIZE,
so unless we're starting at a funny address, they ought to remain
that way...

I wonder if this isn't papering over another bug.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180724/e7beb78c/attachment-0001.sig>

More information about the mesa-dev mailing list