[Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 25 17:31:01 UTC 2018

On 25 July 2018 at 16:28, Erik Faye-Lund <erik.faye-lund at collabora.com> wrote:
> When this bit was added, it seems the some initialization code
> was omitted by mistake.
> Since stack-variables have kinda random contents, and we don't
> zero initialize the whole struct in these code-paths, we end up
> getting random-ish values for this bit.
As a follow-up it'll be a good idea to zero init. the whole stack
variable, removing duplicate zero assignments.
Shorter code, while avoiding similar bugs in the future.

> Fixes: 70425bcfe63c4e9191809659d019ec4af923595d ("gallium: plumb
> invariant output attrib thru TGSI")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>


More information about the mesa-dev mailing list