[Mesa-dev] [PATCH] dri3: Do not get supported modifiers on pixmaps

[Eric Anholt]

Olivier Fourdan <ofourdan at redhat.com> writes:

> get_supported_modifiers() expects a window as drawable, passing a pixmap
> will fail as the Xserver will fail to match the id to a window.
>
> That leads to dri3_alloc_render_buffer() to return NULL and breaks
> rendering when using GLX_DOUBLEBUFFER.
>
> Check if dealing with pixmap in dri3_alloc_render_buffer() in which case
> avoid using get_supported_modifiers() and fallback to the good old
> pixmap_from_buffer() method as before.

It seems like we should ask for the modifiers on the root window in that
case, and use something good from the screen_modifiers list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180725/99a0818f/attachment-0001.sig>