[Mesa-dev] [PATCH 01/12] util/list: Make some helpers take const lists

Thomas Helland thomashelland90 at gmail.com
Thu Jul 26 16:17:19 UTC 2018


This is:
Reviewed-by: Thomas Helland<thomashelland90 at gmail.com>

26. jul. 2018 18.04 skrev "Jason Ekstrand" <jason at jlekstrand.net>:

They're all just querying things about the list and not mutating
anything.
---
 src/util/list.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/util/list.h b/src/util/list.h
index 6edb7501109..09d1b4cae64 100644
--- a/src/util/list.h
+++ b/src/util/list.h
@@ -72,7 +72,7 @@ static inline void list_addtail(struct list_head *item,
struct list_head *list)
     list->prev = item;
 }

-static inline bool list_empty(struct list_head *list);
+static inline bool list_empty(const struct list_head *list);

 static inline void list_replace(struct list_head *from, struct list_head
*to)
 {
@@ -101,7 +101,7 @@ static inline void list_delinit(struct list_head *item)
     item->prev = item;
 }

-static inline bool list_empty(struct list_head *list)
+static inline bool list_empty(const struct list_head *list)
 {
    return list->next == list;
 }
@@ -114,7 +114,7 @@ static inline bool list_is_singular(const struct
list_head *list)
    return list->next != NULL && list->next != list && list->next->next ==
list;
 }

-static inline unsigned list_length(struct list_head *list)
+static inline unsigned list_length(const struct list_head *list)
 {
    struct list_head *node;
    unsigned length = 0;
@@ -145,7 +145,7 @@ static inline void list_splicetail(struct list_head
*src, struct list_head *dst)
    dst->prev = src->prev;
 }

-static inline void list_validate(struct list_head *list)
+static inline void list_validate(const struct list_head *list)
 {
    struct list_head *node;
    assert(list->next->prev == list && list->prev->next == list);
-- 
2.17.1

_______________________________________________
mesa-dev mailing list
mesa-dev at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180726/011871ab/attachment-0001.html>


More information about the mesa-dev mailing list