[Mesa-dev] [PATCH 03/12] nir/print: Remove a bogus assert

[Thomas Helland]

This is already fixed in master it seems

2018-07-26 17:59 GMT+02:00 Jason Ekstrand <jason at jlekstrand.net>:
> In 1beef89ad85c47fb6, we made a bunch of changes to NIR to allow for
> more than four components.  This assert was added to trigger if we ever
> saw a vec16 input variable.  However, it didn't take into account the
> fact that we can get matrices as input/output variables and they break
> this assumption without breaking the code that follows.
>
> Fixes: 1beef89ad85c4 "nir: prepare for bumping up max components to 16"
> ---
>  src/compiler/nir/nir_print.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c
> index 93d1c02f23d..7cb16abd146 100644
> --- a/src/compiler/nir/nir_print.c
> +++ b/src/compiler/nir/nir_print.c
> @@ -491,7 +491,6 @@ print_var_decl(nir_variable *var, print_state *state)
>        switch (var->data.mode) {
>        case nir_var_shader_in:
>        case nir_var_shader_out:
> -         assert(num_components <= 4);
>           if (num_components < 4 && num_components != 0) {
>              const char *xyzw = "xyzw";
>              for (int i = 0; i < num_components; i++)
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev