[Mesa-dev] [PATCH] ac: pass write param to get_sampler_desc() from get_image_descriptor()

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Jul 27 09:06:10 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Fixes: 506a07e4e3a "ac/nir: Add deref support to image intrinsics."

On Fri, Jul 27, 2018 at 7:08 AM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> Looks like a mistake from when the deref stuff landed.
>
> Fixes: 506a07e4e3a4 ("ac/nir: Add deref support to image intrinsics.")
>
> Cc: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 44361be0d35..cffc980e51f 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -2201,7 +2201,7 @@ static LLVMValueRef get_image_descriptor(struct ac_nir_context *ctx,
>                                           enum ac_descriptor_type desc_type,
>                                           bool write)
>  {
> -       return get_sampler_desc(ctx, nir_instr_as_deref(instr->src[0].ssa->parent_instr), desc_type, NULL, true, true);
> +       return get_sampler_desc(ctx, nir_instr_as_deref(instr->src[0].ssa->parent_instr), desc_type, NULL, true, write);
>  }
>
>  static void get_image_coords(struct ac_nir_context *ctx,
> --
> 2.17.1
>


More information about the mesa-dev mailing list