[Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

Tapani Pälli tapani.palli at intel.com
Mon Jul 30 05:22:08 UTC 2018


On 07/25/2018 08:36 AM, Tapani Pälli wrote:
> On 07/24/2018 10:31 PM, Eric Anholt wrote:
>> Tapani Pälli <tapani.palli at intel.com> writes:
>>> These bits were missing, found when extending the Piglit test.
>>> Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing"
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases here?  They
>> aren't required for rendering, but if the implementation supports them
>> we should answer correctly.
> If I've understood correctly, SNORM ones are supported only with 
> EXT_render_snorm so those ones I was planning to add separately. For 
> RGB16 I guess we would need to query the driver. Not sure what would be 
> the best way to achieve this, it seems that at least i965 relies on 
> _mesa_query_internal_format_default which just says to support anything 
> (is broken).

Eric, would it be OK to land this patch? I'll add SNORM ones with 

// Tapani

More information about the mesa-dev mailing list