[Mesa-dev] [PATCH] Make glXChooseFBConfig handle unspecified sRGB correctly

[Eric Anholt]

Jon Turney <jon.turney at dronecode.org.uk> writes:

> Make glXChooseFBConfig properly handle the case where the only matching
> configs have the sRGB flag set, but no sRGB attribute is specified.
>
> Since 6e06e281, the sRGBcapable flag is now actually compared, using
> MATCH_DONT_CARE.
>
> 7b0f912e added defaulting of sRGBcapable to GL_FALSE in
> __glXInitializeVisualConfigFromTags(), to handle servers which don't report
> it, but this function is also used by glXChooseFBConfig(), so sRGBcapable is
> implicitly false when not explicitly specified.
>
> (This can cause e.g. glxinfo to fail to find anything matching the simple
> config it looks for if all the candidates have the sRGB flag set to true.
> I'm assuming this doesn't happen 'normally' as candidate configs with and
> without sRGB true are available)
>
> Move this defaulting to createConfigsFromProperties(), and set the default
> for glXChooseFBConfig() in init_fbconfig_for_chooser() to GLX_DONT_CARE.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180730/00a4d52a/attachment.sig>