[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

[Adam Jackson]

On Fri, 2018-07-27 at 16:16 +0200, Olivier Fourdan wrote:
> Hi,
> 
> On Thu, 26 Jul 2018 at 19:53, Eric Anholt <eric at anholt.net> wrote:
> > 
> > Olivier Fourdan <ofourdan at redhat.com> writes:
> > 
> > > get_supported_modifiers() and pixmap_from_buffers() requests both
> > > expect a window as drawable, passing a pixmap will fail as the Xserver
> > > will fail to match the given drawable to a window.
> > > 
> > > That leads to dri3_alloc_render_buffer() to return NULL and breaks
> > > rendering when using GLX_DOUBLEBUFFER on pixmaps.
> > > 
> > > Query the root window of the pixmap on first init, and use the root
> > > window instead of the pixmap drawable for get_supported_modifiers()
> > > and pixmap_from_buffers().
> > > 
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107117
> > > Fixes: 069fdd5 ("egl/x11: Support DRI3 v1.1")
> > > Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> > 
> > Looks great!
> > 
> > Reviewed-by: Eric Anholt <eric at anholt.net>
> 
> Thanks both Daniel and Eric for the reviews!
> 
> If I may, could someone push that fix for me, I don't think I have
> commit rights in Mesa...
> 
> (It's a regression affecting Mesa 18.1 with Xserver 1.20, would be
> great to have it fixed)

Merged, thanks:

To gitlab.freedesktop.org:mesa/mesa.git
   16b5e15e918..03a61b977e1  master -> master

- ajax