[Mesa-dev] [PATCH v2 1/4] intel/nir: Use the correct scalar stage for consumers when linking

Timothy Arceri tarceri at itsqueeze.com
Tue Jul 31 23:20:24 UTC 2018


I guess you guys may want to look into Ken's comments on patch 3. But 
otherwise the series looks good to me and is:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 01/08/18 05:22, Jason Ekstrand wrote:
> ---
>   src/intel/compiler/brw_nir.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
> index 5990427b731..17ccfa48af6 100644
> --- a/src/intel/compiler/brw_nir.c
> +++ b/src/intel/compiler/brw_nir.c
> @@ -730,7 +730,7 @@ brw_nir_link_shaders(const struct brw_compiler *compiler,
>         *producer = brw_nir_optimize(*producer, compiler, p_is_scalar);
>   
>         const bool c_is_scalar =
> -         compiler->scalar_stage[(*producer)->info.stage];
> +         compiler->scalar_stage[(*consumer)->info.stage];
>         *consumer = brw_nir_optimize(*consumer, compiler, c_is_scalar);
>      }
>   }
> 


More information about the mesa-dev mailing list