[Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

Juan A. Suarez Romero jasuarez at igalia.com
Fri Jun 1 07:43:48 UTC 2018


On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote:
> Hi Laura,
> 
> On 30 May 2018 at 23:53, Laura Ekstrand <laura at jlekstrand.net> wrote:
> > @@ -0,0 +1,9 @@
> > +pages:
> > +   stage: deploy
> > +   script:
> > +   - mkdir .public
> > +   - cp -r docs/* .public
> > +   - mv .public public
> 
> You should be able to just write into the 'public' folder directly.
> 
> It seems like creating a new directory and then moving it is an
> attempt to be atomic, which is absolutely the right thing to do! But
> the Pages deploy is separate: the build starts from a completely clean
> slate, and does not overwrite the live website being served by Pages.
> It's only once the build has finished and the artifacts captured that
> they're later moved in-place to serve Pages.
> 

On top of Daniel suggestion, I would also restrict this job to master job
("only: master"). This way, the pages are not re-deploying wrongly when someone
pushes to a different branch (like an stable branch).


	J.A.


> Cheers,
> Daniel
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list