[Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

Daniel Stone daniel at fooishbar.org
Fri Jun 1 10:23:56 UTC 2018


Hi,

On 1 June 2018 at 09:47, Juan A. Suarez Romero <jasuarez at igalia.com> wrote:
> My question then: is mandatory to call eglSwapBuffers() to ensure
> wl_egl_window_get_attached_size() returns the right window size? Because I
> found nothing related about this. If it is mandatory, then calling
> eglSwapBuffers() in the test should fix the problem (including the patch
> I've summited with Daniel's changes).

In Wayland, surfaces do _not_ have a native size, unlike say GBM
surfaces or X11 surfaces. Buffers obviously have a size, and buffers
are 'attached' to a surface inside eglSwapBuffers by calling
wl_surface_attach(). wl_egl_window_get_attached_size() returns the
size of the last buffer which was actually attached, which is required
for things like correct input handling when resizing.

I'd prefer to fix dEQP to not ask nonsensical questions than try to
fix the answer.

Cheers,
Daniel


More information about the mesa-dev mailing list