[Mesa-dev] [PATCH 2/2] anv/android: Use an address for each anv_image plane

Lionel Landwerlin lionel.g.landwerlin at intel.com
Sun Jun 3 23:49:54 UTC 2018


On 03/06/18 19:41, Mauro Rossi wrote:
> Fixes to avoid building error after change in image->planes[] structure,
> {bo,bo_offset} has to be replaced by address.{bo,offset}
> and update is needed also in the assert() for debug builds.
>
> external/mesa/src/intel/vulkan/anv_android.c:188:21:
> error: no member named 'bo' in 'struct anv_image::(anonymous at external/mesa/src/intel/vulkan/anv_private.h:2647:4)'
>     image->planes[0].bo = bo;
>     ~~~~~~~~~~~~~~~~ ^
> 1 error generated.
>
> Fixes: bf34ef16ac ("anv: Use an address for each anv_image plane")
> Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>

Thanks for the fix!

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

> ---
>   src/intel/vulkan/anv_android.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
> index ed5da5b537..45a21dcfc3 100644
> --- a/src/intel/vulkan/anv_android.c
> +++ b/src/intel/vulkan/anv_android.c
> @@ -183,9 +183,9 @@ anv_image_from_gralloc(VkDevice device_h,
>      }
>   
>      assert(image->n_planes == 1);
> -   assert(image->planes[0].bo_offset == 0);
> +   assert(image->planes[0].address.offset == 0);
>   
> -   image->planes[0].bo = bo;
> +   image->planes[0].address.bo = bo;
>      image->planes[0].bo_is_owned = true;
>   
>      /* We need to set the WRITE flag on window system buffers so that GEM will




More information about the mesa-dev mailing list