[Mesa-dev] [PATCH 00/24] Fix some warnings in gallium/aux

Gert Wollny gert.wollny at collabora.com
Tue Jun 5 11:58:43 UTC 2018


Dear all, 

this series fixes a number of warnings that are issued when compiling with 
-Wextra. Since this flag also includes -Wmissing-field-initializers - a warning
that is rather mis-leading, I also propose to always silence this warning. 

thanks for reviewing, 
Gert

PS: I have no commit rights

Gert Wollny (24):
  configure.ac: Add CFLAG -Wno-missing-field-initializers
  gallium/aux/cso_cache: Fix various warnings
  gallium/aux/tgsi/tgsi_dump.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi/tgsi_parse.c: Fix two warnings
  gallium/aux/tgsi_sanity.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_aa_point.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_exec.c: Remove paramater inst from exec_kill
  gallium/aux/tgsi_exec.c: Remove unused parameter from
    fetch_src_file_channel
  gallium/aux/tgsi_exec.c: remove superfluous parameter from
    store_dest_dstret
  gallium/aux/tgsi_exec.c: remove superfluous parameter from
    etch_source_d
  gallium/aux/tgsi_exec.c: Fix various -Wsign-compare
  gallium/aux/tgsi_build.c: Remove unused parameters prev_token from
    various functions
  gallium/aux/tgsi_build.c: Remove now unused variable
  gallium/aux/tgsi_build.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_lowering.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_point_sprite.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_text.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_ureg.c: Fix various warnings
  gallium/aux/tgsi_two_side.c: Fix -Wsign-compare warnings
  gallium/aux/tgsi_ureg.c: remove unused parameter from
    match_or_expand_immediate64
  gallium/aux/util: Fix some warnings
  gallium/aux/util/u_debug.h: Fix "noreturn" warnings in debug mode
  gallium/aux/util/u_cpu_detect.h: Fix -Wsign-compare warning in
    u_cpu_detect.c
  gallium/aux/os: Fix warning/handle failure to read from
    /proc/self/cmdline

 configure.ac                                   |  2 ++
 src/gallium/auxiliary/cso_cache/cso_cache.c    | 12 +++----
 src/gallium/auxiliary/cso_cache/cso_context.c  |  2 +-
 src/gallium/auxiliary/os/os_process.c          | 28 +++++++++------
 src/gallium/auxiliary/tgsi/tgsi_aa_point.c     |  4 +--
 src/gallium/auxiliary/tgsi/tgsi_build.c        | 22 +++---------
 src/gallium/auxiliary/tgsi/tgsi_dump.c         |  2 +-
 src/gallium/auxiliary/tgsi/tgsi_exec.c         | 49 ++++++++++----------------
 src/gallium/auxiliary/tgsi/tgsi_lowering.c     |  6 ++--
 src/gallium/auxiliary/tgsi/tgsi_parse.c        | 10 ++++--
 src/gallium/auxiliary/tgsi/tgsi_point_sprite.c | 13 +++----
 src/gallium/auxiliary/tgsi/tgsi_sanity.c       |  4 +--
 src/gallium/auxiliary/tgsi/tgsi_text.c         |  8 ++---
 src/gallium/auxiliary/tgsi/tgsi_two_side.c     |  7 ++--
 src/gallium/auxiliary/tgsi/tgsi_ureg.c         |  9 +++--
 src/gallium/auxiliary/tgsi/tgsi_util.c         |  2 +-
 src/gallium/auxiliary/util/u_cpu_detect.c      |  2 +-
 src/gallium/auxiliary/util/u_cpu_detect.h      |  2 +-
 src/gallium/auxiliary/util/u_debug.h           |  4 +--
 src/gallium/auxiliary/util/u_hash_table.c      |  2 +-
 src/gallium/auxiliary/util/u_tests.c           |  2 +-
 21 files changed, 91 insertions(+), 101 deletions(-)

-- 
2.16.4



More information about the mesa-dev mailing list