[Mesa-dev] [PATCH] radv: fix Coverity no effect control flow issue

[Samuel Pitoiset]

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 06/07/2018 01:49 AM, Timothy Arceri wrote:
> swizzle is unsigned so "desc->swizzle[c] < 0" is never true.
> ---
>   src/amd/vulkan/radv_formats.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index 50ec904d514..958f2a2c821 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -921,7 +921,7 @@ bool radv_format_pack_clear_color(VkFormat format,
>   	uint64_t clear_val = 0;
>   
>   	for (unsigned c = 0; c < 4; ++c) {
> -		if (desc->swizzle[c] < 0 || desc->swizzle[c] >= 4)
> +		if (desc->swizzle[c] >= 4)
>   			continue;
>   
>   		const struct vk_format_channel_description *channel = &desc->channel[desc->swizzle[c]];
>