[Mesa-dev] [PATCH 4/4] meson: remove a bunch of out of date TODO's

Dylan Baker dylan at pnwbakers.com
Thu Jun 7 18:53:09 UTC 2018


Some of these are done already, some of them are things we're not going
to do, like have a toggle for GLX_TLS.

Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
---
 meson.build         | 11 -----------
 src/egl/meson.build |  2 --
 src/gbm/meson.build |  2 --
 3 files changed, 15 deletions(-)

diff --git a/meson.build b/meson.build
index ff3e768362d..e47a522d6a7 100644
--- a/meson.build
+++ b/meson.build
@@ -345,7 +345,6 @@ if with_glvnd
   endif
 endif
 
-# TODO: toggle for this
 with_glx_direct = true
 
 if with_vulkan_icd_dir == ''
@@ -1207,8 +1206,6 @@ if get_option('selinux')
   pre_args += '-DMESA_SELINUX'
 endif
 
-# TODO: llvm-prefix and llvm-shared-libs
-
 if with_libunwind != 'false'
   dep_unwind = dependency('libunwind', required : with_libunwind == 'true')
   if dep_unwind.found()
@@ -1218,8 +1215,6 @@ else
   dep_unwind = null_dep
 endif
 
-# TODO: gallium-hud
-
 if with_osmesa != 'none'
   if with_osmesa == 'classic' and not with_dri_swrast
     error('OSMesa classic requires dri (classic) swrast.')
@@ -1240,8 +1235,6 @@ if with_osmesa != 'none'
   endif
 endif
 
-# TODO: symbol mangling
-
 if with_platform_wayland
   prog_wl_scanner = find_program('wayland-scanner')
   dep_wl_protocols = dependency('wayland-protocols', version : '>= 1.8')
@@ -1342,10 +1335,6 @@ else
   dep_lmsensors = null_dep
 endif
 
-# TODO: various libdirs
-
-# TODO: gallium driver dirs
-
 foreach a : pre_args
   add_project_arguments(a, language : ['c', 'cpp'])
 endforeach
diff --git a/src/egl/meson.build b/src/egl/meson.build
index dc67b7b1536..b11695e01fc 100644
--- a/src/egl/meson.build
+++ b/src/egl/meson.build
@@ -140,8 +140,6 @@ if with_platform_haiku
   deps_for_egl += cpp.find_library('be')
 endif
 
-# TODO: glvnd
-
 if cc.has_function('mincore')
   c_args_for_egl += '-DHAVE_MINCORE'
 endif
diff --git a/src/gbm/meson.build b/src/gbm/meson.build
index 7a60868783c..2e9d380c0b4 100644
--- a/src/gbm/meson.build
+++ b/src/gbm/meson.build
@@ -45,8 +45,6 @@ if with_platform_wayland
   incs_gbm += inc_wayland_drm
 endif
 
-# TODO: wayland support (requires egl)
-
 libgbm = shared_library(
   'gbm',
   files_gbm,
-- 
2.17.1



More information about the mesa-dev mailing list