[Mesa-dev] [PATCH 1/2] gallium: add scalar isa cap

Christian Gmeiner christian.gmeiner at gmail.com
Fri Jun 8 09:07:59 UTC 2018


Am Fr., 8. Juni 2018 um 05:42 Uhr schrieb Marek Olšák <maraeo at gmail.com>:
>
> radeonsi is scalar.
>

Thanks for the info.. will be fixed in V2.

> Marek
>
> On Thu, Jun 7, 2018 at 3:32 PM, Christian Gmeiner <christian.gmeiner at gmail.com> wrote:
>>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
>> ---
>>  src/gallium/docs/source/screen.rst               | 2 +-
>>  src/gallium/drivers/etnaviv/etnaviv_screen.c     | 1 +
>>  src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
>>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 1 +
>>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 1 +
>>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 1 +
>>  src/gallium/drivers/svga/svga_screen.c           | 3 +++
>>  src/gallium/drivers/v3d/v3d_screen.c             | 1 +
>>  src/gallium/drivers/vc4/vc4_screen.c             | 1 +
>>  src/gallium/include/pipe/p_defines.h             | 1 +
>>  10 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
>> index 0f18b7a94b..f45dc5f0a9 100644
>> --- a/src/gallium/docs/source/screen.rst
>> +++ b/src/gallium/docs/source/screen.rst
>> @@ -438,7 +438,7 @@ PIPE_CONSERVATIVE_RASTER_PRE_SNAP mode is supported for points and lines.
>>  works with conservative rasterization.
>>  * ``PIPE_CAP_MAX_CONSERVATIVE_RASTER_SUBPIXEL_PRECISION_BIAS``: The maximum
>>  subpixel precision bias in bits during conservative rasterization.
>> -
>> +* ``PIPE_CAP_SCALAR_ISA``: Whether the GPU has a scalar ISA.
>>
>>  .. _pipe_capf:
>>
>> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> index e031807117..3936e0aa4e 100644
>> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> @@ -281,6 +281,7 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>     case PIPE_CAP_CONSERVATIVE_RASTER_POST_DEPTH_COVERAGE:
>>     case PIPE_CAP_MAX_CONSERVATIVE_RASTER_SUBPIXEL_PRECISION_BIAS:
>>     case PIPE_CAP_PACKED_UNIFORMS:
>> +   case PIPE_CAP_SCALAR_ISA:
>>        return 0;
>>
>>     /* Stream output. */
>> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
>> index a414cb6d60..d943d1c1f1 100644
>> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
>> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
>> @@ -186,6 +186,7 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>         case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>>         case PIPE_CAP_TEXTURE_BARRIER:
>>         case PIPE_CAP_INVALIDATE_BUFFER:
>> +       case PIPE_CAP_SCALAR_ISA:
>>                 return 1;
>>
>>         case PIPE_CAP_VERTEXID_NOBASE:
>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> index a77f70e6bb..f7566958f9 100644
>> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> @@ -95,6 +95,7 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>>     case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>>     case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>> +   case PIPE_CAP_SCALAR_ISA:
>>        return 1;
>>     /* nv35 capabilities */
>>     case PIPE_CAP_DEPTH_BOUNDS_TEST:
>> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
>> index 2495a545fd..5c4993b313 100644
>> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
>> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
>> @@ -201,6 +201,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>     case PIPE_CAP_TGSI_CLOCK:
>>     case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>     case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>> +   case PIPE_CAP_SCALAR_ISA:
>>        return 1;
>>     case PIPE_CAP_SEAMLESS_CUBE_MAP:
>>        return 1; /* class_3d >= NVA0_3D_CLASS; */
>> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> index f679cbdba3..8fb315a5aa 100644
>> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> @@ -259,6 +259,7 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>     case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>     case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>     case PIPE_CAP_QUERY_SO_OVERFLOW:
>> +   case PIPE_CAP_SCALAR_ISA:
>>        return 1;
>>     case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>>        return nouveau_screen(pscreen)->vram_domain & NOUVEAU_BO_VRAM ? 1 : 0;
>> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
>> index 2744f3100e..449aa5359b 100644
>> --- a/src/gallium/drivers/svga/svga_screen.c
>> +++ b/src/gallium/drivers/svga/svga_screen.c
>> @@ -287,6 +287,9 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>     case PIPE_CAP_SM3:
>>        return 1;
>>
>> +   case PIPE_CAP_SCALAR_ISA:
>> +      return 1;
>> +
>>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>>     case PIPE_CAP_INDEP_BLEND_ENABLE:
>>     case PIPE_CAP_CONDITIONAL_RENDER:
>> diff --git a/src/gallium/drivers/v3d/v3d_screen.c b/src/gallium/drivers/v3d/v3d_screen.c
>> index d578265eef..27e38b993c 100644
>> --- a/src/gallium/drivers/v3d/v3d_screen.c
>> +++ b/src/gallium/drivers/v3d/v3d_screen.c
>> @@ -109,6 +109,7 @@ v3d_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>          case PIPE_CAP_DRAW_INDIRECT:
>>          case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>>          case PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET:
>> +        case PIPE_CAP_SCALAR_ISA:
>>                  return 1;
>>
>>          case PIPE_CAP_INDEP_BLEND_ENABLE:
>> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
>> index 6415d95746..3f6896ab8b 100644
>> --- a/src/gallium/drivers/vc4/vc4_screen.c
>> +++ b/src/gallium/drivers/vc4/vc4_screen.c
>> @@ -146,6 +146,7 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>          case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>>          case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>          case PIPE_CAP_TEXTURE_BARRIER:
>> +        case PIPE_CAP_SCALAR_ISA:
>>                  return 1;
>>
>>          case PIPE_CAP_NATIVE_FENCE_FD:
>> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
>> index 6cc73a31bf..de280585d7 100644
>> --- a/src/gallium/include/pipe/p_defines.h
>> +++ b/src/gallium/include/pipe/p_defines.h
>> @@ -813,6 +813,7 @@ enum pipe_cap
>>     PIPE_CAP_CONSERVATIVE_RASTER_PRE_SNAP_POINTS_LINES,
>>     PIPE_CAP_MAX_CONSERVATIVE_RASTER_SUBPIXEL_PRECISION_BIAS,
>>     PIPE_CAP_CONSERVATIVE_RASTER_POST_DEPTH_COVERAGE,
>> +   PIPE_CAP_SCALAR_ISA,
>>  };
>>
>>  /**
>> --
>> 2.17.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info


More information about the mesa-dev mailing list