[Mesa-dev] [PATCH mesa] autotools/meson: compile against wayland-egl-*backend*

[Dylan Baker]

Quoting Eric Engestrom (2018-06-08 07:46:01)
> On Friday, 2018-06-08 15:38:41 +0100, Emil Velikov wrote:
> > On 8 June 2018 at 12:26, Eric Engestrom <eric.engestrom at intel.com> wrote:
> > > Suggested-by: Emil Velikov <emil.l.velikov at gmail.com>
> > > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106861
> > Fixes: ...
> 
> Thanks; already added locally, didn't want to resend just for that :)
> 
> > 
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -1202,7 +1202,7 @@ if with_platform_wayland
> > >    dep_wayland_client = dependency('wayland-client', version : '>=1.11')
> > >    dep_wayland_server = dependency('wayland-server', version : '>=1.11')
> > >    if with_egl
> > > -    dep_wayland_egl = dependency('wayland-egl', version : '>=1.15')
> > > +    dep_wayland_egl = dependency('wayland-egl-backend', version : '>= 3')
> > The dep_wayland_egl should be a header only dependency, alike dep_va_headers.
> 
> The pkg-config only provides a header include path anyway; is it worth the effort?
> (not so much code effort, but maintenance effort of having a special case here)

Since the pkg_config only provides headers we could just call it *_headers :)
Otherwise I vote just leave it, I don't think it's worth trying to special case
something that doesn't need to be, especially since it's such a pain to do so
until meson 0.46, when we get language support for headers-only dependencies

Dylan

> > 
> > With that the patch is
> > Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Thanks :)
> 
> > 
> > Thanks
> > Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180608/ef5e6718/attachment.sig>