[Mesa-dev] [PATCH 4/4] meson: remove a bunch of out of date TODO's

[Emil Velikov]

On 7 June 2018 at 19:53, Dylan Baker <dylan at pnwbakers.com> wrote:
> Some of these are done already, some of them are things we're not going
> to do, like have a toggle for GLX_TLS.
>
> Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> ---
>  meson.build         | 11 -----------
>  src/egl/meson.build |  2 --
>  src/gbm/meson.build |  2 --
>  3 files changed, 15 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index ff3e768362d..e47a522d6a7 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -345,7 +345,6 @@ if with_glvnd
>    endif
>  endif
>
> -# TODO: toggle for this
i don't see anything handling this. Am I missing something, or you
misread it as GLX_TLS?

>  with_glx_direct = true
>
>  if with_vulkan_icd_dir == ''
> @@ -1207,8 +1206,6 @@ if get_option('selinux')
>    pre_args += '-DMESA_SELINUX'
>  endif
>
> -# TODO: llvm-prefix and llvm-shared-libs
> -
The meson llvm wrapper nicely handles the prefix, but I don't see it
handling the shared/static part.
Plus distros have both the (multiple) static and (single) shared LLVM,
last time I've checked.

Perhaps we should keep the latter TODO for now?

With Eric's suggestions and the above nits, the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil