[Mesa-dev] [PATCH] radv: fix missing ZRANGE_PRECISION(1) for GFX9+

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Fri Jun 8 20:30:59 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Jun 8, 2018 at 5:59 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> ZRANGE_PRECISION(1) seems to be the default optimal value, but
> it was only set for VI and older chips.
>
> This fixes a rendering issue with Banished through DXVK, and
> might fix more than that.
>
> There is still the ZRANGE_PRECISION bug that we need to handle
> but that can be fixed later.
>
> Cc: mesa-stable at lists.freedesktop.org
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 68bd1757824..5936b43093e 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -3969,7 +3969,8 @@ radv_initialise_ds_surface(struct radv_device *device,
>                 ds->db_z_info = S_028038_FORMAT(format) |
>                         S_028038_NUM_SAMPLES(util_logbase2(iview->image->info.samples)) |
>                         S_028038_SW_MODE(iview->image->surface.u.gfx9.surf.swizzle_mode) |
> -                       S_028038_MAXMIP(iview->image->info.levels - 1);
> +                       S_028038_MAXMIP(iview->image->info.levels - 1) |
> +                       S_028038_ZRANGE_PRECISION(1);
>                 ds->db_stencil_info = S_02803C_FORMAT(stencil_format) |
>                         S_02803C_SW_MODE(iview->image->surface.u.gfx9.stencil.swizzle_mode);
>
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list