[Mesa-dev] [PATCH 16/23] intel/eu: Assert that the instruction is send-like in brw_set_desc_ex().

Francisco Jerez currojerez at riseup.net
Tue Jun 12 02:26:08 UTC 2018


Constructing a descriptor in-place as part of the immediate of an ALU
instruction is no longer supported.
---
 src/intel/compiler/brw_eu_emit.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c
index 86c5c4bb3d2..9649ee00b07 100644
--- a/src/intel/compiler/brw_eu_emit.c
+++ b/src/intel/compiler/brw_eu_emit.c
@@ -368,11 +368,12 @@ brw_set_desc_ex(struct brw_codegen *p, brw_inst *inst,
                 unsigned desc, unsigned ex_desc)
 {
    const struct gen_device_info *devinfo = p->devinfo;
+   assert(brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SEND ||
+          brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SENDC);
    brw_inst_set_src1_file_type(devinfo, inst,
                                BRW_IMMEDIATE_VALUE, BRW_REGISTER_TYPE_D);
    brw_inst_set_send_desc(devinfo, inst, desc);
-   if (devinfo->gen >= 9 && (brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SEND ||
-                             brw_inst_opcode(devinfo, inst) == BRW_OPCODE_SENDC))
+   if (devinfo->gen >= 9)
       brw_inst_set_send_ex_desc(devinfo, inst, ex_desc);
 }
 
-- 
2.16.1



More information about the mesa-dev mailing list