[Mesa-dev] [PATCH v2 6/6] meson: remove a bunch of out of date TODO's

[Dylan Baker]

Quoting Eric Engestrom (2018-06-12 05:08:57)
> On Monday, 2018-06-11 10:19:01 -0700, Dylan Baker wrote:
> > Some of these are done already, some of them are things we're not going
> > to do, like have a toggle for GLX_TLS.
> 
> I'm not 100% sure which is which, and I might not be the only one;
> could you split these two into two patches? Thanks :)
> 
> The rest of the series is:
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> 
> > 
> > v2: - Don't remove USE_MGL_NAMESPACE or with_glx_direct
> > 
> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> > ---
> >  meson.build         | 8 --------
> >  src/egl/meson.build | 2 --
> >  src/gbm/meson.build | 2 --
> >  3 files changed, 12 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index bee526a4f22..aefb9f3c85e 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1217,8 +1217,6 @@ if get_option('selinux')
> >    pre_args += '-DMESA_SELINUX'
> >  endif
> >  
> > -# TODO: llvm-prefix and llvm-shared-libs
> > -

This was the only one left that was "not going to do", and Emil asked me to
leave it for now and I forgot. I've dropped this hunk and reworked the commit
message to say "meson: remove various completed todos"

> >  if with_libunwind != 'false'
> >    dep_unwind = dependency('libunwind', required : with_libunwind == 'true')
> >    if dep_unwind.found()
> > @@ -1228,8 +1226,6 @@ else
> >    dep_unwind = null_dep
> >  endif
> >  
> > -# TODO: gallium-hud
> > -
> >  if with_osmesa != 'none'
> >    if with_osmesa == 'classic' and not with_dri_swrast
> >      error('OSMesa classic requires dri (classic) swrast.')
> > @@ -1354,10 +1350,6 @@ else
> >    dep_lmsensors = null_dep
> >  endif
> >  
> > -# TODO: various libdirs
> > -
> > -# TODO: gallium driver dirs
> > -
> >  foreach a : pre_args
> >    add_project_arguments(a, language : ['c', 'cpp'])
> >  endforeach
> > diff --git a/src/egl/meson.build b/src/egl/meson.build
> > index 8d888d35aff..5f30bbba89a 100644
> > --- a/src/egl/meson.build
> > +++ b/src/egl/meson.build
> > @@ -140,8 +140,6 @@ if with_platform_haiku
> >    deps_for_egl += cpp.find_library('be')
> >  endif
> >  
> > -# TODO: glvnd
> > -
> >  if cc.has_function('mincore')
> >    c_args_for_egl += '-DHAVE_MINCORE'
> >  endif
> > diff --git a/src/gbm/meson.build b/src/gbm/meson.build
> > index 7a60868783c..2e9d380c0b4 100644
> > --- a/src/gbm/meson.build
> > +++ b/src/gbm/meson.build
> > @@ -45,8 +45,6 @@ if with_platform_wayland
> >    incs_gbm += inc_wayland_drm
> >  endif
> >  
> > -# TODO: wayland support (requires egl)
> > -
> >  libgbm = shared_library(
> >    'gbm',
> >    files_gbm,
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180612/3c5ce833/attachment.sig>