[Mesa-dev] [PATCH v4 075/129] nir: convert lower_samplers_as_deref to deref instructions

Kenneth Graunke kenneth at whitecape.org
Wed Jun 13 09:06:27 UTC 2018


On Tuesday, June 12, 2018 5:54:31 PM PDT Rob Clark wrote:
> On Tue, Jun 12, 2018 at 6:34 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > On Thursday, May 31, 2018 10:04:05 PM PDT Jason Ekstrand wrote:
> >> From: Rob Clark <robdclark at gmail.com>
> >>
> >> This also removes the legacy version of lower_samplers.
> >
> > It does not, that's what patch 76 (the next one) does.
> >
> 
> (for lack of good way of viewing full patchset atm, I'll take your
> word for that, but that said) maybe just add the words "need for" into
> that sentence, rather than squashing this and the following patch
> together, to reduce the noise in the patch history..
> 
> BR,
> -R

Yeah, definitely, I'd just change the message, not the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180613/9b7a5b14/attachment.sig>


More information about the mesa-dev mailing list