[Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

[Jon Turney]

On 12/06/2018 16:53, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-06-12 04:25:10)
>> Copied from configure.ac:1950
>>
>> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
>> ---
>> Is it still needed? We've been building on MacOS for a while,
>> yet nobody noticed anything (Dylan?)
>> If not, we should probably avoid unnecessary differences with Khronos'
>> headers and nuke BUILDING_MESA.
>> ---
>>   meson.build | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meson.build b/meson.build
>> index c5acc8a3587ea20e131e..04b3bdfd77f36670ff7f 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -209,6 +209,7 @@ endif
>>   
>>   if host_machine.system() == 'darwin'
>>     with_dri_platform = 'apple'
>> +  pre_args += '-DBUILDING_MESA'
>>   elif ['windows', 'cygwin'].contains(host_machine.system())
>>     with_dri_platform = 'windows'
>>   elif system_has_kms_drm
>> -- 
>> Cheers,
>>    Eric
>>
> 
> I didn't notice, but I also didn't do a whole lot of testing
> 
> I've added Jon who did most of the meson mac work and Jeremy who's the resident
> mac expert.
> 
No expert, but I believe this is unfortunately still needed.

See commit c7f36574 and the referenced BZ.