[Mesa-dev] [PATCH] virgl: increase command size buffer a bit for constant buffers.

[Alex Deucher]

On Thu, Jun 14, 2018 at 11:13 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> If we want to upload 16k 32-bit consts we need a bit of overhead
> to faciliate that.
>
> Fixes crash in:
> KHR-GL44.geometry_shader.limits.max_uniform_components
> ---
>  src/gallium/drivers/virgl/virgl_winsys.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/virgl/virgl_winsys.h b/src/gallium/drivers/virgl/virgl_winsys.h
> index cf67b827e82..f1fa823bf6d 100644
> --- a/src/gallium/drivers/virgl/virgl_winsys.h
> +++ b/src/gallium/drivers/virgl/virgl_winsys.h
> @@ -31,7 +31,7 @@ struct pipe_fence_handle;
>  struct winsys_handle;
>  struct virgl_hw_res;
>
> -#define VIRGL_MAX_CMDBUF_DWORDS (16*1024)
> +#define VIRGL_MAX_CMDBUF_DWORDS (16*1025)

Maybe add a comment here?  This seems like the kind of thing someone
will try and "fix" at some point.

Alex

>
>  struct virgl_drm_caps {
>     union virgl_caps caps;
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev