[Mesa-dev] [PATCH mesa] radv: fix bitwise check
Samuel Pitoiset
samuel.pitoiset at gmail.com
Fri Jun 15 19:58:20 UTC 2018
Oops.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
On 06/15/2018 07:00 PM, Eric Engestrom wrote:
> Fixes: 922cd38172b8a2bc286bd "radv: implement out-of-order rasterization when it's safe on VI+"
> Cc: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
> src/amd/vulkan/radv_pipeline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index ccbcbbadd55e672a572a..113622bb0ce1ea0f88f7 100644
> --- a/src/amd/vulkan/radv_pipeline.c
> +++ b/src/amd/vulkan/radv_pipeline.c
> @@ -622,7 +622,7 @@ radv_blend_check_commutativity(struct radv_blend_state *blend,
> (1u << VK_BLEND_FACTOR_ONE_MINUS_SRC1_ALPHA);
>
> if (dst == VK_BLEND_FACTOR_ONE &&
> - (src_allowed && (1u << src))) {
> + (src_allowed & (1u << src))) {
> /* Addition is commutative, but floating point addition isn't
> * associative: subtle changes can be introduced via different
> * rounding. Be conservative, only enable for min and max.
>
More information about the mesa-dev
mailing list