[Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

Marek Olšák maraeo at gmail.com
Mon Jun 18 20:54:57 UTC 2018


On Mon, Jun 18, 2018 at 4:41 PM, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
wrote:

> On Mon, Jun 18, 2018 at 10:39 PM, Marek Olšák <maraeo at gmail.com> wrote:
> > On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen
> > <bas at basnieuwenhuizen.nl> wrote:
> >>
> >> On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák <maraeo at gmail.com> wrote:
> >> > Do you need this if you set compressZ = true for stencil?
> >>
> >> Technically not, then you don't hit the path anymore. Anyway even
> >> though neither AMDVLK or RADV anymore if we do that, it still bugged
> >> me that the index is wrong.
> >
> >
> > The way I update addrlib is that I copy all files from the internal repo
> > into Mesa and then maybe discard some Mesa-specific changes. This change
> is
> > very likely to get overwritten, so I would like to prevent addrlib
> changes
> > that don't have any impact on current Mesa.
>
> If I want to fix it "upstream", is the addrlib copy in
> https://github.com/GPUOpen-Drivers/pal the right place to update?
>

No, that one is an imported copy too. If you want to fix this in the
original repository, you can send the patch to my amd address.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180618/a30d52b0/attachment.html>


More information about the mesa-dev mailing list