[Mesa-dev] [PATCH 1/2] radv: Don't check for pipeline being set in draw.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jun 19 08:06:46 UTC 2018


Draws without pipeline are definitely not allowed.

Fixes Coverity issue 1434216.
---
 src/amd/vulkan/radv_cmd_buffer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index ccaab63b84b..992d67606d0 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -3366,7 +3366,6 @@ radv_draw(struct radv_cmd_buffer *cmd_buffer,
 		cmd_buffer->device->physical_device->rad_info.chip_class >= CIK;
 	bool pipeline_is_dirty =
 		(cmd_buffer->state.dirty & RADV_CMD_DIRTY_PIPELINE) &&
-		cmd_buffer->state.pipeline &&
 		cmd_buffer->state.pipeline != cmd_buffer->state.emitted_pipeline;
 
 	MAYBE_UNUSED unsigned cdw_max =
-- 
2.17.1



More information about the mesa-dev mailing list