[Mesa-dev] [PATCH] mesa: fix GLES 3.1 version calculation

Rob Clark robdclark at gmail.com
Tue Jun 19 13:34:02 UTC 2018


On Tue, Jun 19, 2018 at 9:08 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 19 June 2018 at 13:53, Rob Clark <robdclark at gmail.com> wrote:
>> All of ARB_gpu_shader5 is most certainly not required for GLES 3.1
>> (most of it is in OES_gpu_shader5 on top of GLES 3.1).
>>
>> Some of what is required from ARB_gpu_shader5 is provided by
>> ARB_texture_gather, so check for that.  The remaining subset of
>> ARB_gpu_shader5 doesn't have individual extensions to check for,
>> but I guess it is unlikely that some driver has all of these
>> extensions but not, say, integer bitfield manipulation.
>>
> Fly-by idea - worth adding a fixes tag?
>
> Fixes: 1fe243938b1 ("mesa/es3.1: Enable ES 3.1 API and shading
> language version")
>

it's not *quite* fixes, and will really only matter when I land a5xx
MSAA support (which obviously won't end up in a stable kernel branch),
so I think we don't really need Fixes tag in this case..

(but yes, I do try to include those when I think something is
candidate for a release branch)

BR,
-R


More information about the mesa-dev mailing list