[Mesa-dev] [PATCH] gallium: Fix automake for Android

Emil Velikov emil.l.velikov at gmail.com
Tue Jun 19 15:14:03 UTC 2018

Hello gents,

On 19 June 2018 at 14:34, Tomasz Figa <tfiga at chromium.org> wrote:

>> --- a/src/gallium/auxiliary/Makefile.am
>> +++ b/src/gallium/auxiliary/Makefile.am
>> @@ -21,6 +21,10 @@ libgallium_la_SOURCES = \
>>         $(NIR_SOURCES) \
>> +libgallium_la_SOURCES += util/u_debug_stack_android.cpp
> Shouldn't we add ANDROID_CFLAGS and ANDROID_LIBS here rather than in
> src/gallium/Automake.inc, since this is the module that actually needs
> them?
Tl;Dr: Either one will work.

Longer version:
Your suggestion makes the current relation more obvious, although
Chad's approach is more robust in the long run.
Think: other parts of mesa using the $new_module or $new_module being
a static library. In the latter case you'll end up with multiple
conflicting declarations in the final link.

I doubt these cases are applicable here, so either approach will be fine ;-)

With Tomasz' suggestions, the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>


More information about the mesa-dev mailing list