[Mesa-dev] [PATCH] mesa: fix GLES 3.1 version calculation

[Ilia Mirkin]

On Tue, Jun 19, 2018 at 9:38 AM, Rob Clark <robdclark at gmail.com> wrote:
> On Tue, Jun 19, 2018 at 9:09 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Tue, Jun 19, 2018 at 8:53 AM, Rob Clark <robdclark at gmail.com> wrote:
>>> All of ARB_gpu_shader5 is most certainly not required for GLES 3.1
>>> (most of it is in OES_gpu_shader5 on top of GLES 3.1).
>>>
>>> Some of what is required from ARB_gpu_shader5 is provided by
>>> ARB_texture_gather, so check for that.  The remaining subset of
>>
>> ARB_texture_gather is actually a subset of what's needed for ES 3.1,
>> gather-wise. I think ES 3.1 has component selection in the shader, and
>> potentially non-const offsets (neither of which ARB_texture_gather
>> has).
>>
>
> hmm, don't we have a lowering pass for some of that (for a4xx)?

That pass relies on some a4xx specifics (it generates
otherwise-illegal texelFetch combos), and I'm not 100% sure it's legal
to do it that way, with texel fetches. Also often the gather offset
range differs from the texel fetch offset range.

  -ilia