[Mesa-dev] [PATCH mesa] i915g: allow staging textures to be used

Eric Engestrom eric.engestrom at intel.com
Tue Jun 19 16:57:25 UTC 2018


On Tuesday, 2018-06-19 06:42:24 -0700, Jason Ekstrand wrote:
> Do we test 915g in CI? I thought we tested 915 classic.

Oh, I didn't think of that, good point, I don't know how the CI
actually builds mesa.
Is that something I can see somewhere?

> 
> On June 19, 2018 02:44:20 Eric Engestrom <eric.engestrom at intel.com> wrote:
> 
> > Fixes: 1a69b50b3b441ce8f7a00 "i915g: Fix point sprites."
> > Cc: St├ęphane Marchesin <marcheu at chromium.org>
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > ---
> > St├ęphane, I assume this was an accident, given that there's no mention
> > of forcing it off in the commit message or in any comment?
> > Intel CI is happy with this patch, so it doesn't seem like there was
> > a bug left to fix before turning it on or anything.
> > ---
> > src/gallium/drivers/i915/i915_resource_texture.c | 2 --
> > 1 file changed, 2 deletions(-)
> > 
> > diff --git a/src/gallium/drivers/i915/i915_resource_texture.c
> > b/src/gallium/drivers/i915/i915_resource_texture.c
> > index 4ade04f223c022804b10..856c015ed4037cf816e6 100644
> > --- a/src/gallium/drivers/i915/i915_resource_texture.c
> > +++ b/src/gallium/drivers/i915/i915_resource_texture.c
> > @@ -748,8 +748,6 @@ i915_texture_transfer_map(struct pipe_context *pipe,
> >        !(usage & (PIPE_TRANSFER_READ | PIPE_TRANSFER_DONTBLOCK |
> > PIPE_TRANSFER_UNSYNCHRONIZED)))
> >       use_staging_texture = TRUE;
> > 
> > -   use_staging_texture = FALSE;
> > -
> >    if (use_staging_texture) {
> >       /*
> >        * Allocate the untiled staging texture.
> > --
> > Cheers,
> >  Eric
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list