[Mesa-dev] [PATCH] anv, radv: Add support for VK_KHR_get_display_properties2

Keith Packard keithp at keithp.com
Wed Jun 20 00:01:05 UTC 2018

Jason Ekstrand <jason at jlekstrand.net> writes:

I see two styles here -- get_physical_device_display_properties* both
use a helper function that takes a pointer to either of the property
returns while get_physical_device_display_plane_properties* and
get_display_mode_properties* open-code things.

I'm easy with which style you pick, but I think they should be the
same. I have a mild preference for the second style as I think it's
easier to read the code without all of the conditionals.

As for the actual implementation of each function, it looks good, so
I'll actually mark this as

Reviewed-by: Keith Packard <keithp at keithp.com>

If you want to rework the first bit, I'll review whatever changes you
make. If you just want to rebase and push, you've got my Rb above :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180619/6aa73d8d/attachment.sig>

More information about the mesa-dev mailing list