[Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

Kenneth Graunke kenneth at whitecape.org
Thu Jun 21 09:14:28 UTC 2018

On Tuesday, June 12, 2018 12:44:44 PM PDT Kenneth Graunke wrote:
> On Thursday, May 31, 2018 10:01:43 PM PDT Jason Ekstrand wrote:
> > Ideally, I'd like the series to get some amount of real review before it
> > lands.  Honestly, it's been baking long enough and tested by enough people
> > on enough drivers that we can probably throw a bunch of Acked-by and
> > Tested-bys on it and call it a day but I'd rather not.  I plan to review
> > all of the patches I didn't write but that will have to wait until
> > tomorrow.
> > 
> > At the very least, I'd like some sort of an ACK from a variety of the
> > people that use NIR on the core concept and the sort of general shape of
> > things at the end of the series.  A lot of work has gone into this but it's
> > also a big change and the more positive feedback it gets, the more
> > comfortable I'll be pulling the trigger.
> Patches 1-28 are
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patches 1-105 and 123-129 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patch 106 (opt_copy_prop_vars) is also R-b assuming that you fix the
bug that I pointed out in my reply there.

I ran out of energy for reviewing the ac/radv/radeonsi patches...not
sure anyone really needs me to anyway.  I think you're good to go on
this series, at least from my point of view.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180621/842dffe0/attachment.sig>

More information about the mesa-dev mailing list