[Mesa-dev] [PATCH 1/3] radv: change the returned error in radv_signal_fence()

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jun 21 12:39:28 UTC 2018


>From my point of view, when we aren't able to submit a CS
something terribly wrong happens and we are most likely
going to lost the device.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_device.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index ffeb6450b3..3c63d8c86d 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -2470,9 +2470,8 @@ static VkResult radv_signal_fence(struct radv_queue *queue,
 	                                   false, fence->fence);
 	radv_free_sem_info(&sem_info);
 
-	/* TODO: find a better error */
 	if (ret)
-		return vk_error(queue->device->instance, VK_ERROR_OUT_OF_DEVICE_MEMORY);
+		return vk_error(queue->device->instance, VK_ERROR_DEVICE_LOST);
 
 	return VK_SUCCESS;
 }
-- 
2.17.1



More information about the mesa-dev mailing list