[Mesa-dev] [PATCH] radv: enable VK_EXT_shader_stencil_export

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jun 26 08:08:55 UTC 2018


Did not see that we already had tests for it.

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Mon, Jun 25, 2018 at 3:56 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> The driver already supports exporting the stencil value.
>
> The following CTS test now pass:
> dEQP-VK.pipeline.shader_stencil_export.op_replace
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_extensions.py | 1 +
>  src/amd/vulkan/radv_shader.c      | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
> index ebc3f6bc2b..a0f1038110 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -100,6 +100,7 @@ EXTENSIONS = [
>      Extension('VK_EXT_global_priority',                   1, 'device->rad_info.has_ctx_priority'),
>      Extension('VK_EXT_sampler_filter_minmax',             1, 'device->rad_info.chip_class >= CIK'),
>      Extension('VK_EXT_shader_viewport_index_layer',       1, True),
> +    Extension('VK_EXT_shader_stencil_export',             1, True),
>      Extension('VK_EXT_vertex_attribute_divisor',          1, True),
>      Extension('VK_AMD_draw_indirect_count',               1, True),
>      Extension('VK_AMD_gcn_shader',                        1, True),
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index 03185de304..c7ffd47c0b 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -222,6 +222,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
>                                 .shader_viewport_index_layer = true,
>                                 .descriptor_array_dynamic_indexing = true,
>                                 .runtime_descriptor_array = true,
> +                               .stencil_export = true,
>                         },
>                 };
>                 entry_point = spirv_to_nir(spirv, module->size / 4,
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list