[Mesa-dev] [PATCH 01/19] radeonsi: clean up passing the is_monolithic flag for compilation

[Marek Olšák]

On Tue, Jun 26, 2018, 4:09 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 26 June 2018 at 01:48, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> > On 26/06/18 09:51, Dieter Nützel wrote:
> >>
> >> Hello Marek,
> >>
> >> after this series landed I get this:
> >>
> >> Making all in targets/pipe-loader
> >> make[4]: Verzeichnis „/opt/mesa/src/gallium/targets/pipe-loader“ wird
> >> betreten
> >>    CXXLD    pipe_r600.la
> >>
> >>
> ../../../../src/gallium/winsys/radeon/drm/.libs/libradeonwinsys.a(radeon_drm_surface.o):
> >> In function `radeon_winsys_surface_init':
> >> /opt/mesa/src/gallium/winsys/radeon/drm/radeon_drm_surface.c:307:
> >> undefined reference to `ac_compute_cmask'
> >> collect2: error: ld returned 1 exit status
> >> make[4]: *** [Makefile:970: pipe_r600.la] Fehler 1
> >>
> >> Didn't have more time for digging, yet.
> >
> >
> > r600 probably doesn't get linked to the amd common (ac) code that is
> > normally just shared between radv and radeonsi.
> >
> Precisely. A quick and simple solution would be to duplicate the
> function in winsys/radeon.
> Since neither R300 nor R600 require AC [or the addrlib that gets
> pulled], this might be the less invasive workaround.
>
> What do you guys think?
>

I agree with the duplication.

Marek

>
> -Emil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180626/3d610697/attachment.html>