[Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

Drew Davenport ddavenport at chromium.org
Tue Jun 26 23:00:07 UTC 2018


This change lets the following test pass on virgl:
dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv
---
 src/gallium/drivers/virgl/virgl_screen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
index 1eefbd6519f..3035d4b5e20 100644
--- a/src/gallium/drivers/virgl/virgl_screen.c
+++ b/src/gallium/drivers/virgl/virgl_screen.c
@@ -495,6 +495,10 @@ virgl_is_format_supported( struct pipe_screen *screen,
    }
 
    if (bind & PIPE_BIND_RENDER_TARGET) {
+      /* For ARB_framebuffer_no_attachments. */
+      if (format == PIPE_FORMAT_NONE)
+         return TRUE;
+
       if (format_desc->colorspace == UTIL_FORMAT_COLORSPACE_ZS)
          return FALSE;
 
-- 
2.16.4



More information about the mesa-dev mailing list