[Mesa-dev] [PATCH] i965/bufmgr: Use the correct argument order for bo_alloc_internal

Kenneth Graunke kenneth at whitecape.org
Wed Jun 27 06:08:24 UTC 2018


On Tuesday, June 26, 2018 6:33:40 PM PDT Jason Ekstrand wrote:
> The memzone and flags parameters were accidentally flipped in the call
> from brw_bo_alloc_tiled_2d.
> ---
>  src/mesa/drivers/dri/i965/brw_bufmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> index 7ac3bcad3da..09d45e30ecc 100644
> --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c
> +++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> @@ -720,8 +720,8 @@ brw_bo_alloc_tiled_2d(struct brw_bufmgr *bufmgr, const char *name,
>     if (tiling == I915_TILING_NONE)
>        stride = 0;
>  
> -   return bo_alloc_internal(bufmgr, name, size, flags,
> -                            memzone, tiling, stride);
> +   return bo_alloc_internal(bufmgr, name, size, memzone,
> +                            flags, tiling, stride);
>  }
>  
>  /**
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180626/3c5ca2fb/attachment.sig>


More information about the mesa-dev mailing list