[Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

[Ilia Mirkin]

On Tue, Jun 26, 2018 at 7:00 PM, Drew Davenport <ddavenport at chromium.org> wrote:
> This change lets the following test pass on virgl:
> dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv
> ---
>  src/gallium/drivers/virgl/virgl_screen.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
> index 1eefbd6519f..3035d4b5e20 100644
> --- a/src/gallium/drivers/virgl/virgl_screen.c
> +++ b/src/gallium/drivers/virgl/virgl_screen.c
> @@ -495,6 +495,10 @@ virgl_is_format_supported( struct pipe_screen *screen,
>     }
>
>     if (bind & PIPE_BIND_RENDER_TARGET) {
> +      /* For ARB_framebuffer_no_attachments. */
> +      if (format == PIPE_FORMAT_NONE)
> +         return TRUE;
> +

This has to be gated on the host driver supporting this functionality,
right? I.e. ES 3.1 or having this ext.

Also dEQP has a lot of no-fb tests (unfortunately I don't remember
what they're called off-hand... maybe *no_framebuffer* or
*no_attach*), you should ensure they all pass (or fail for
known/understood reasons).

Cheers,

  -ilia