[Mesa-dev] [PATCH 2/2] anv/android: Fix type error in call to vk_errorf()

Chad Versace chadversary at chromium.org
Thu Jun 28 03:40:50 UTC 2018


In a single call to vk_errorf() in the Android code, the arguments were
swapped. The bug has existed since day one. Chrome OS used to forgive
the warning, but it is now a compilation error.

Fixes: 053d4c32 "anv: Implement VK_ANDROID_native_buffer (v9)"
Cc: Tapani Pälli <tapani.palli at intel.com>
Cc: Tomasz Figa <tfiga at chromium.org>
---
 src/intel/vulkan/anv_android.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 3c905d3bdb5..a3bab8087b4 100644
--- a/src/intel/vulkan/anv_android.c
+++ b/src/intel/vulkan/anv_android.c
@@ -180,7 +180,7 @@ anv_image_from_gralloc(VkDevice device_h,
       goto fail_create;
 
    if (bo->size < image->size) {
-      result = vk_errorf(device, device->instance,
+      result = vk_errorf(device->instance, device,
                          VK_ERROR_INVALID_EXTERNAL_HANDLE_KHR,
                          "dma-buf from VkNativeBufferANDROID is too small for "
                          "VkImage: %"PRIu64"B < %"PRIu64"B",
-- 
2.18.0.rc2.346.g013aa6912e-goog



More information about the mesa-dev mailing list