[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v2]

[Erik Faye-Lund]

On Thu, Jun 28, 2018 at 11:12 PM Fritz Koenig <frkoenig at google.com> wrote:
>
> Adds an extension to glFramebufferParameteri
> that will specify if the framebuffer is vertically
> flipped. Historically system framebuffers are
> vertically flipped and user framebuffers are not.
> Checking to see the state was done by looking at
> the name field.  This adds an explicit field.
>
> v2:
> * updated spec language [for chadv]
> * correctly specifying ES 3.1 [for chadv]
> * refactor access to rb->Name [for jason]
> * handle GetFramebufferParameteriv [for chadv]
> ---
>  docs/specs/MESA_framebuffer_flip_y.spec    | 84 ++++++++++++++++++++++
>  include/GLES2/gl2ext.h                     |  5 ++
>  src/mapi/glapi/registry/gl.xml             |  6 ++
>  src/mesa/drivers/dri/i915/intel_fbo.c      |  7 +-
>  src/mesa/drivers/dri/i965/intel_fbo.c      |  7 +-
>  src/mesa/drivers/dri/nouveau/nouveau_fbo.c |  7 +-
>  src/mesa/drivers/dri/radeon/radeon_fbo.c   |  7 +-
>  src/mesa/drivers/dri/radeon/radeon_span.c  |  9 ++-
>  src/mesa/drivers/dri/swrast/swrast.c       |  7 +-
>  src/mesa/drivers/osmesa/osmesa.c           |  5 +-
>  src/mesa/drivers/x11/xm_buffer.c           |  3 +-
>  src/mesa/drivers/x11/xmesaP.h              |  3 +-
>  src/mesa/main/accum.c                      | 17 +++--
>  src/mesa/main/dd.h                         |  3 +-
>  src/mesa/main/extensions_table.h           |  1 +
>  src/mesa/main/fbobject.c                   | 18 ++++-
>  src/mesa/main/framebuffer.c                |  1 +
>  src/mesa/main/glheader.h                   |  3 +
>  src/mesa/main/mtypes.h                     |  3 +
>  src/mesa/main/readpix.c                    | 20 +++---
>  src/mesa/state_tracker/st_cb_fbo.c         |  7 +-
>  src/mesa/swrast/s_blit.c                   | 17 +++--
>  src/mesa/swrast/s_clear.c                  |  3 +-
>  src/mesa/swrast/s_copypix.c                | 11 +--
>  src/mesa/swrast/s_depth.c                  |  6 +-
>  src/mesa/swrast/s_drawpix.c                | 26 ++++---
>  src/mesa/swrast/s_renderbuffer.c           |  6 +-
>  src/mesa/swrast/s_renderbuffer.h           |  3 +-
>  src/mesa/swrast/s_stencil.c                |  3 +-
>  29 files changed, 241 insertions(+), 57 deletions(-)
>  create mode 100644 docs/specs/MESA_framebuffer_flip_y.spec
>

I think this needs to update the _mesa_is_winsys_fbo-check in
_mesa_GetMultisamplefv in src/mesa/main/multisample.c to flip the
sample-positions as well...